Skip to content

update release action and scripts #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2021
Merged

update release action and scripts #18

merged 2 commits into from
Apr 3, 2021

Conversation

dominikg
Copy link
Member

port pnpm caching from ci workflow
use node14
add guard for forks
update release script to call changeset publish in hope it does tag and generate proper changelog entries.

@dominikg
Copy link
Member Author

@pngwn what do you think? as long as changesets is in prerelease mode it should publish 1.0.0-next.x to latest but with tagging, no?

@pngwn
Copy link
Member

pngwn commented Mar 27, 2021

It will tag and create releases via the action but I'm not convinced it will use latest tags because you wouldn't normally want to tag next releases with latest if you had an existing release version.

I think it will respect the tag version defined when you entered prerelease mode. Which I think is next in this case. The same question is being asked on the kit repo and I need to do some digging to figure out how to do it. I'll up date as soon i know more.

@dominikg
Copy link
Member Author

fixed a mistake i made when porting the caching. I'll try to get a vite-plugin-svelte release published this weekend. If all goes well the pattern can be applied to sveltekit too.

@dominikg dominikg merged commit 0e516a3 into main Apr 3, 2021
@dominikg dominikg deleted the use-changeset-publish branch April 17, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants